-
Notifications
You must be signed in to change notification settings - Fork 485
Add Container Registry API #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Container Registry API #368
Conversation
| /* | ||
| This function is not implemented because we need the library to support FormData on DELETE requests. | ||
| See: https://docs.gitlab.com/ee/api/container_registry.html#delete-repository-tags-in-bulk | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PhilippeVienne
It is highly unusual to have form data with the DELETE method. Have you tried this with query params?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just following the curl request set as example on the GitLab documentation. I will have a try with params.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PhilippeVienne
Let me know how it goes. If it requires form data, I'll add a delete() method that accepts form data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My local test have correctly a 202 Accepted response but the bulk DELETE seems to fail in all situation, as stated by documentation and also as you suggested with Query Params
|
@PhilippeVienne I am going to go ahead and merge this PR. Once merged, I'll look into and implement the bulk delete functionality. I will also create the |
|
@PhilippeVienne |
Pull request to resolve: #367