added some apis #204
added some apis #204
Conversation
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>fastjson</artifactId>
<version>1.2.47</version>
</dependency>
2.added a method to get languages used in a project.
merge from source
zhengrenjie
changed the title
|
Added a pom dependency: fastjson and added a method to get languages used in a project. |
gmessner
left a comment
gmessner
left a comment
There was a problem hiding this comment.
Thank you for your contribution. I do have a few requested changes:
- Remove the dependency on com.alibaba.fastjson
- Change
getLanguages()as described below. - This library follows a convention where there is a one-to-one mapping of GitLab API documentation page to an API Class, so the markdown methods belong in a new class to be called
MarkdownApiand the license template methods belong in a class calledLicensesApi
You'll need to add the 2 classes and add them to GitLabApi.java
|
|
||
| package org.gitlab4j.api; | ||
|
|
||
| import com.alibaba.fastjson.JSONObject; |
There was a problem hiding this comment.
There is no need to introduce this to the project. See my comments on getLangauge() below.
| Response response = post(expectedStatus, (Form) null, "projects", getProjectIdOrPath(projectIdOrPath), "unstar"); | ||
| return (response.readEntity(Project.class)); | ||
| } | ||
|
|
There was a problem hiding this comment.
No need to introduce a new type for this, please re-implement getProjectLanguage(Integer projectId) as follows:
/**
* Get languages used in a project with percentage value.
*
* Get /projects/:id/languages
*
* @param projectId the ID of the project
* @return a Map instance with the language as the key and the percentage as the value
* @throws GitLabApiException if any exception occurs
* @since GitLab 10.8
*/
public Map<String, Float> getProjectLanguages(Integer projectId) throws GitLabApiException {
if (projectId == null) {
throw new RuntimeException("projectId cannot be null");
}
Response response = get(Response.Status.OK, null, "projects", projectId, "languages");
return (response.readEntity(new GenericType<Map<String, Float>>() { }));
}
pom.xml
Outdated
| <groupId>com.alibaba</groupId> | ||
| <artifactId>fastjson</artifactId> | ||
| <version>1.2.47</version> | ||
| </dependency> |
There was a problem hiding this comment.
No need to introduce this new library, see my comments in ProjectApi.java
|
@gmessner Thank you very much for your suggestion. I will submit it again after the revision. |
Added 2 classes and moved the corresponding methods to. Added 2 members LicensesApi & MarkdownApi to GitLabApi.java. Repaired getProjectLanguage(Integer projectId) as requested.
|
I have completed the changes.if there are any questions please tell me, I'll fix them. |
|
Great job and making the requested changes. |
|
@zhengrenjie |
2 participants
No description provided.