Project API "Upload a file" and "Push Rules"

[jflefebvre06]

Could you please add méthods to projectApi to upload file (https://docs.gitlab.com/ee/api/projects.html#upload-a-file) and manage push rules (https://docs.gitlab.com/ee/api/projects.html#push-rules)

[gmessner]

These will be added in the next release of GitLab4J, scheduled for the week of 4/16/2018.

[jflefebvre06]

@gmessner Thanks a lot

[gmessner]

@jflefebvre06
I noticed what I believe is a bug with the GitLab API docs for updating and deleting a push rule.
Unfortunately, I do not have access to an EE version of GitLab so I cannot test. The problem is that there is no push rule ID specified in the docs when updating or deleting, see:

https://docs.gitlab.com/ee/api/projects.html#edit-project-push-rule
https://docs.gitlab.com/ee/api/projects.html#delete-project-push-rule

Notice that no push rule ID is specified. I'm pretty sure that the push rule ID should be the last item in the URL, can you confirm that the following is correct?

PUT /projects/:id/push_rule/:push_rule_id
DELETE /projects/:id/push_rule/:push_rule_id

Just released 4.8.10 with this functionality, if you can manually test I would appreciate it.

[gmessner]

@jflefebvre06
Just pinging you to see if you had an opportunity to test the Push Rule functionality?

[gmessner]

@jflefebvre06
Because I do not have a GitLab-EE license I was unable to test the push rule methods. I've taken some time and explored the source code for gitlab-ee and am now certain I did not implement them correctly.
I am refactoring and will do a release later today.

[gmessner]

@jflefebvre06
The reworked push rule support is completed and released. Would greatly appreciate it if you could test the new functionality. I cannot test because this is a GitLab-EE feature.

[gmessner]

@jflefebvre06
I'm going to assume that the push rules functionality is working and close this issue. If you find that the push rules functionality is not working, please re-open this issue.

[jflefebvre06]

Hello,
I am very sorry for the delay, I was at the hospital ...
It not seems to work, when I try to update pushrules I get InboundJaxrsResponse{context=ClientResponse{method=POST, uri=https://iXXX/api/v4/projects/6433/push_rule, status=422, reason=Unprocessable Entity}}

[gmessner]

@jflefebvre06
Hope you are doing better.

Unfortunately I am not able to debug this issue because I do not have access to a GitLab Enterprise Edition server. The PushRules only work on GitLab-EE, it would be very helpful if you were able to debug and fix.

[jflefebvre06]

Sure, I will try to do IT ASAP