Skip to content

feat(settings): display username on logout hover #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2024
Merged

feat(settings): display username on logout hover #969

merged 1 commit into from
Apr 6, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Apr 6, 2024

Screenshot 2024-04-06 at 8 19 53 AM

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Apr 6, 2024
@setchy setchy added this to the Release 5.3.0 milestone Apr 6, 2024
@setchy setchy merged commit 624594d into main Apr 6, 2024
@setchy setchy deleted the feature/logout-username branch April 6, 2024 21:51
bmulholland
bmulholland reviewed Apr 8, 2024
View reviewed changes
src/routes/Settings.tsx
<button
className={footerButtonClass}
title="Logout"
title={`Logout ${accounts.user.login}`}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Logout of "?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logout from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty even - https://trends.google.com/trends/explore?q=Logout%20of,Logout%20from&hl=en

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmulholland bmulholland bmulholland left review comments

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

Assignees
No one assigned
Labels
enhancement New feature or enhancement to existing functionality
Milestone
Release 5.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@setchy @bmulholland