Skip to content

feat: bring back ability to click full notification row #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2024
Merged

feat: bring back ability to click full notification row #968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7f9e8f
feat: bring back ability to click full notification row
setchy Apr 6, 2024
28ee1ea
feat: bring back ability to click full notification row
setchy Apr 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/components/NotificationRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,13 @@ export const NotificationRow: React.FC<IProps> = ({
unsubscribeNotification(notification.id, hostname);
};

const openUserProfile = (event: React.MouseEvent<HTMLElement>) => {
// Don't trigger onClick of parent element.
event.stopPropagation();

openExternalLink(notification.subject.user.html_url);
};

const reason = formatReason(notification.reason);
const NotificationIcon = getNotificationTypeIcon(notification.subject);
const iconColor = getNotificationTypeIconColor(notification.subject);
Expand Down Expand Up @@ -80,11 +87,10 @@ export const NotificationRow: React.FC<IProps> = ({
<NotificationIcon size={18} aria-label={notification.subject.type} />
</div>

<div className="flex-1 overflow-hidden">
<div className="flex-1 overflow-hidden" onClick={() => pressTitle()}>
<div
className="mb-1 text-sm whitespace-nowrap overflow-ellipsis overflow-hidden cursor-pointer"
role="main"
onClick={() => pressTitle()}
title={notification.subject.title}
>
{notification.subject.title}
Expand All @@ -101,9 +107,7 @@ export const NotificationRow: React.FC<IProps> = ({
<span
className="cursor-pointer"
title="View User Profile"
onClick={() =>
openExternalLink(notification.subject.user.html_url)
}
onClick={openUserProfile}
>
{notification.subject.user.login}
</span>
Expand Down
2 changes: 1 addition & 1 deletion src/components/__snapshots__/NotificationRow.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ exports[`components/NotificationRow.tsx should render itself & its children 1`]
</div>
<div
className="flex-1 overflow-hidden"
onClick={[Function]}
>
<div
className="mb-1 text-sm whitespace-nowrap overflow-ellipsis overflow-hidden cursor-pointer"
onClick={[Function]}
role="main"
title="I am a robot and this is a test!"
>
Expand Down