Skip to content

refactor: make explicit the different user types #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 25, 2024
Merged

refactor: make explicit the different user types #924

merged 3 commits into from
Mar 25, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Mar 25, 2024

Previously, a shared User type was being used to represent

  • Gitify Auth User - persisted once after authentication
  • Response object for Issues/PRs
  • Enhanced Subject details for Gitify

This update makes the types separate and explicit

@setchy setchy added the refactor Refactoring of existing feature label Mar 25, 2024
@setchy setchy marked this pull request as draft March 25, 2024 12:11
@setchy setchy marked this pull request as ready for review March 25, 2024 12:16
bmulholland
bmulholland approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice cleanup, always good to split up jumbled concepts, thank you!

@setchy setchy merged commit c7776ab into main Mar 25, 2024
@setchy setchy deleted the refactor/user-types branch March 25, 2024 15:51
@setchy setchy added this to the 5.1.0 milestone Mar 27, 2024
afonsojramos
afonsojramos reviewed Mar 28, 2024
View reviewed changes
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos afonsojramos left review comments

@bmulholland bmulholland bmulholland approved these changes

Assignees
No one assigned
Labels
refactor Refactoring of existing feature
Milestone
Release 5.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@setchy @bmulholland @afonsojramos