Skip to content

fix: improve error handling #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 20, 2024
Merged

fix: improve error handling #901

merged 5 commits into from
Mar 20, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Mar 19, 2024 •
edited
Loading

Improve handling of attributes which may be null or responses that may be null.

I found some of these causing issues when testing locally

@setchy setchy added refactor Refactoring of existing feature test Enhancements to test coverage or quality and removed test Enhancements to test coverage or quality labels Mar 19, 2024
bmulholland
bmulholland reviewed Mar 20, 2024
View reviewed changes
bmulholland
bmulholland reviewed Mar 20, 2024
View reviewed changes
bmulholland
bmulholland reviewed Mar 20, 2024
View reviewed changes
bmulholland
bmulholland reviewed Mar 20, 2024
View reviewed changes
bmulholland
bmulholland reviewed Mar 20, 2024
View reviewed changes
bmulholland
bmulholland approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and suggestions, but overall this is a lot of hardening, thank you!

@setchy setchy merged commit 40eec85 into gitify-app:main Mar 20, 2024
adufr pushed a commit to adufr/gitify that referenced this pull request Mar 25, 2024
@setchy @adufr
fix: improve error handling (gitify-app#901)
c22fa59 
* fix: improve error handling

* fix: improve error handling

* incorporate pr feedback

* Merge remote-tracking branch 'origin/main' into bugfix/improve-error-handling
@setchy setchy added this to the Release 5.0.0 milestone Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmulholland bmulholland bmulholland approved these changes

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

Assignees

No one assigned

Labels

refactor Refactoring of existing feature

Milestone

Release 5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@setchy @bmulholland