Skip to content

Conversation

setchy
Copy link
Member

@setchy setchy commented Mar 11, 2024

Before
Screenshot 2024-03-14 at 7 40 11 AM

After
Screenshot 2024-03-11 at 3 03 23 PM

@setchy setchy added the refactor Refactoring of existing feature label Mar 11, 2024
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That icon feels soulless. I'd prefer to stay with the current one, at least with the current design of gitify.

@afonsojramos
Copy link
Member

afonsojramos commented Mar 12, 2024

Or maybe I just need to get used to it... I'm going to leave it simmering 🥘

But if we do it, we should join #873 #874 and #876 with this one. It doesn't make sense to have them in separate PRs imo

@setchy
Copy link
Member Author

setchy commented Mar 12, 2024

Or maybe I just need to get used to it... I'm going to leave it simmering 🥘

Simmer away 😉. I noticed that the octicons are much sharper.

But if we do it, we should join #873 #874 and #876 with this one. It doesn't make sense to have them in separate PRs imo

Personal preference perhaps... I'm very much in favor of small, independent, isolated PRs to assist with review speed and keep the line changed to the smallest releasable, particularly with refactoring PRs

@afonsojramos
Copy link
Member

Right, but in this case you are introducing icons that don't play well with each other if not done on one go.

I feel like if we switch to these icons we also need to completely revamp our UI to properly mimick GitHub's UI. As is, I still think ours are perfectly fine. If we do do these UI changes, then I think the icon changes make total sense

@setchy
Copy link
Member Author

setchy commented Mar 15, 2024

In the interest of moving this forward, I've consolidated into a single PR #885

@setchy setchy closed this Mar 15, 2024
@setchy setchy deleted the refactor/cog-icon-primer branch March 18, 2024 15:01
@setchy setchy changed the title refactor(icons): replace cog icon with octicons prime version refactor(icons): replace cog icon with octicons primer version Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring of existing feature
Development

Successfully merging this pull request may close these issues.

2 participants