Skip to content

Conversation

setchy
Copy link
Member

@setchy setchy commented Mar 3, 2024

Improve match accuracy by using regex to extract all CheckSuite title attributes

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Mar 3, 2024
@setchy
Copy link
Member Author

setchy commented Mar 3, 2024

Coverage check failing due to how the percentage is calculated. All lines are covered

Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find and nice improvement! Local testing looks good as well!

@afonsojramos afonsojramos merged commit cddd3c3 into gitify-app:main Mar 3, 2024
@setchy setchy deleted the feature/checksuite-regex branch March 3, 2024 11:48
adufr pushed a commit to adufr/gitify that referenced this pull request Mar 25, 2024
* feat: use regex to extract all checksuite attributes

* feat: use regex to extract all checksuite attributes

* feat: use regex to extract all checksuite attributes
@setchy setchy added this to the Release 5.0.0 milestone Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Development

Successfully merging this pull request may close these issues.

2 participants