Skip to content

Conversation

setchy
Copy link
Member

@setchy setchy commented Mar 1, 2024

Refactor existing logic to use state for CheckSuite notification types.

Added more tests

@setchy setchy changed the title refactor: use state to pass checksuite status around refactor: use state for inferred checksuite status Mar 1, 2024
@setchy
Copy link
Member Author

setchy commented Mar 1, 2024

coverage/coveralls job failure is due to how the percentage is calculated.

Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

@bmulholland bmulholland merged commit e9cacd5 into gitify-app:main Mar 3, 2024
@setchy setchy deleted the refactor/checksuite-state branch March 3, 2024 09:46
adufr pushed a commit to adufr/gitify that referenced this pull request Mar 25, 2024
* refactor: use state to pass checksuite status around

* refactor tests
@setchy setchy added the refactor Refactoring of existing feature label Mar 27, 2024
@setchy setchy added this to the Release 5.0.0 milestone Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring of existing feature
Development

Successfully merging this pull request may close these issues.

2 participants