Skip to content

Conversation

setchy
Copy link
Member

@setchy setchy commented Feb 21, 2024

Update Subject type to match API response shape

  • will always contain url, either string or null
  • will always contain latest_comment_url, either string or null
  • may contain a state. Some notifications don't provide this value (eg: Release, RepositoryInvitation etc)

@setchy
Copy link
Member Author

setchy commented Feb 22, 2024

I have raised github/docs#31783 to have the upstream docs triaged and amended

@setchy setchy merged commit 3fb6f14 into gitify-app:main Feb 22, 2024
@setchy setchy deleted the refactor/update-subject-types branch February 22, 2024 19:48
adufr pushed a commit to adufr/gitify that referenced this pull request Mar 25, 2024
@setchy setchy added the refactor Refactoring of existing feature label Mar 27, 2024
@setchy setchy added this to the Release 5.0.0 milestone Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring of existing feature
Development

Successfully merging this pull request may close these issues.

2 participants