Skip to content

deps: remove coveralls #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2023
Merged

deps: remove coveralls #690

merged 1 commit into from
Dec 8, 2023

Conversation

afonsojramos
Copy link
Member

It seems that we're only using the GH action, not the package, so we should be free to remove this.

bmulholland
bmulholland approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Why draft?

@afonsojramos afonsojramos marked this pull request as ready for review December 8, 2023 18:03
@afonsojramos
Copy link
Member Author

I just wanted to make sure that nothing would break and forgot about it 😅

@afonsojramos afonsojramos merged commit f5a5ac0 into main Dec 8, 2023
@afonsojramos afonsojramos deleted the deps/remove-coveralls branch December 8, 2023 18:04
@setchy setchy added the dependency Dependency updates label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmulholland bmulholland bmulholland approved these changes

Assignees
No one assigned
Labels
dependency Dependency updates
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afonsojramos @bmulholland @setchy