chore: remove lodash and emojione
#675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonsojramos
force-pushed
the
chore/clean-dependencies
branch
from
40ad52e to
a5e6b27
Compare
|
On the other hand, maybe OS emojis will make it feel more natural in that environment? Hard to say. We could try it. Easy to roll back :) |
bmulholland
reviewed
Oct 18, 2023
bmulholland
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small experiment of removal of lodash and emojione, our biggest culprits in terms of bundle size.
Regarding lodash, it is a no brainer. It removes almost 600Kb and it doesn't affect readability that much, if at all.
Regarding emojione, I'm a bit torn, because we would be relying on the OS render of the emojis, which means that emojis will look different depending on where it is running. Which reduces consistency (?)
Before
After