chore(CI): don't run tests twice per PR #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @JoseAlberola! I really appreciate you helping out with tasks :) This change has a bit of collateral damage: it wouldn't run tests on the main branch. We need those so we can ensure the build is still working. Could you update the config so that still works? |
bmulholland
approved these changes
Oct 9, 2023
bmulholland
changed the title
|
You are welcome! I hope this configuration works for you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves #646 by modifying the .github/workflows/run-test file to just execute the test on the pull request not in the push. Before tests were executed twice.
Signed-off-by: JoseAlberola