Skip to content

chore(deps): Upgrade to Jest 29 #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2023
Merged

chore(deps): Upgrade to Jest 29 #617

merged 2 commits into from
Oct 2, 2023

Conversation

bmulholland
Copy link
Collaborator

No description provided.

@bmulholland bmulholland force-pushed the 09-27-Upgrade_to_Jest_28 branch from f4dc0ff to 910608c Compare September 28, 2023 08:48
@bmulholland bmulholland force-pushed the 09-27-Upgrade_to_Jest_29 branch from 753d107 to f6ee899 Compare September 28, 2023 08:48
This was referenced Sep 28, 2023
Merged
Merged
Merged
Merged
@bmulholland
Copy link
Collaborator Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@bmulholland bmulholland force-pushed the 09-27-Upgrade_to_Jest_28 branch from 910608c to 7b8a4af Compare September 28, 2023 08:50
@bmulholland bmulholland force-pushed the 09-27-Upgrade_to_Jest_29 branch from f6ee899 to 676168e Compare September 28, 2023 08:50
@bmulholland
Copy link
Collaborator Author

bmulholland commented Sep 28, 2023 •
edited
Loading

@afonsojramos Upgrading these packages required several chained upgrades. I used Graphite, a tool which makes it easy to stack changes like this, to break them up instead of having one massive PR. Graphite can also handle merging all of them without having to manually rebase -- just review + approve, and I can hit one button to make that all happen. (Or, you can set up an account with Graphite, and do that yourself via their UI.)

The only thing left before I'm comfortable merging it all is manually testing the React upgrade. See my comment there.

bmulholland
bmulholland commented Sep 28, 2023
View reviewed changes
@bmulholland bmulholland mentioned this pull request Sep 28, 2023
Closed
1 task
@afonsojramos afonsojramos force-pushed the 09-27-Upgrade_to_Jest_28 branch from 7b8a4af to c4586c0 Compare September 28, 2023 10:05
Base automatically changed from 09-27-Upgrade_to_Jest_28 to main September 28, 2023 10:08
@afonsojramos
Copy link
Member

without having to manually rebase -- just review + approve

lol, read this after manually rebasing/merging everything :)

@afonsojramos
Copy link
Member

@bmulholland is the button a premium feature? can't see it anywhere :( But Graphite looks really cool, thanks for the tip!

@bmulholland
Copy link
Collaborator Author

No, it's free. Top right of https://app.graphite.dev/github/pr/gitify-app/gitify/617/chore-deps-Upgrade-to-Jest-29

You have to use it before the conflict happens though :\

@afonsojramos afonsojramos force-pushed the 09-27-Upgrade_to_Jest_29 branch from 676168e to b4fad01 Compare September 28, 2023 10:28
@bmulholland bmulholland force-pushed the 09-27-Upgrade_to_Jest_29 branch from b4fad01 to a65edaa Compare October 2, 2023 08:02
@bmulholland
Copy link
Collaborator Author

bmulholland commented Oct 2, 2023 •
edited
Loading

@afonsojramos Should be good to go now :). Need your review to merge.

@afonsojramos afonsojramos merged commit 286c415 into main Oct 2, 2023
@afonsojramos afonsojramos deleted the 09-27-Upgrade_to_Jest_29 branch October 2, 2023 08:07
@setchy setchy added the dependency Dependency updates label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos afonsojramos approved these changes

Assignees
No one assigned
Labels
dependency Dependency updates
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmulholland @afonsojramos @setchy