Skip to content

Conversation

afonsojramos
Copy link
Member

@afonsojramos afonsojramos commented Sep 25, 2023

Add repo scope to the token creation link to conform with the Login With An Access Token page.
image

The repo scope has been added in #538

@afonsojramos afonsojramos linked an issue Sep 25, 2023 that may be closed by this pull request
@bmulholland
Copy link
Collaborator

What's this needed for?

@afonsojramos
Copy link
Member Author

@bmulholland added the details to the description.

@bmulholland
Copy link
Collaborator

Sounds good! Looks like the change was clobbered, though?

@afonsojramos
Copy link
Member Author

Sounds good! Looks like the change was clobbered, though?

I suppose that users can still remove the repo token if they're not comfortable with giving it, but for the default behaviour I suppose that we should aim to get maximum compat.

@bmulholland
Copy link
Collaborator

I don’t think we’re talking about the same thing… I was saying that the diff is currently zero lines of code :)

@afonsojramos
Copy link
Member Author

Must have gotten mangled by the merge, sorry about that!

@afonsojramos afonsojramos added this pull request to the merge queue Sep 26, 2023
@afonsojramos afonsojramos removed this pull request from the merge queue due to the queue being cleared Sep 26, 2023
@afonsojramos afonsojramos merged commit 279d248 into main Sep 26, 2023
@afonsojramos afonsojramos deleted the 495-documentation-personal-access-token branch September 26, 2023 09:54
@setchy setchy added the enhancement New feature or enhancement to existing functionality label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Development

Successfully merging this pull request may close these issues.

Documentation: Personal Access Token
3 participants