Skip to content

Conversation

afonsojramos
Copy link
Member

@afonsojramos afonsojramos commented May 21, 2023

Some of the versions of the CI were no longer supported. Opted for going for latest, as latest in this context does not mean that it is not a mature platform.

yarn was also posing a blocker after upgrading the versions, so I decided to also take advantage to switch to pnpm, a community favorite that brings a few of advantages over yarn classic. This made it so that a few packages needed to be updated, as well as added, since pnpm is more strict with regards to dependencies.

@afonsojramos afonsojramos changed the title chore: update runs-on versions feat: switch to pnpm & update runs-on versions May 21, 2023
@afonsojramos afonsojramos changed the title feat: switch to pnpm & update runs-on versions feat: switch to pnpm & update runs-on versions & packages May 22, 2023
@afonsojramos afonsojramos mentioned this pull request May 22, 2023
@afonsojramos afonsojramos requested a review from bmulholland May 22, 2023 09:58
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! It's always part pain, part satisfying to bring a project up to date.

You might also consider setting up renovate to automate the package updates. I'd suggest dependabot but they don't support pnpm, which is why I mention it in this context :)

@afonsojramos
Copy link
Member Author

@bmulholland I actually use depfu in another repository, but yeah, renovate, other than dependabot, is the industry standard. I'll try to get that set up.

@afonsojramos afonsojramos merged commit 6e6edd1 into main May 22, 2023
@afonsojramos afonsojramos deleted the ci/fix-ci-versions branch May 22, 2023 10:05
@bmulholland
Copy link
Collaborator

I use Depfu on a private repo, too. I don't think it supports pnpm though.

If you want to install Renovate, I've done it a few times. Here's the quick way to get it installed:

  1. Go to https://github.com/apps/renovate and install it for the repo
  2. It will auto-create a PR "Configure Renovate" with a suggested config
  3. I'd suggest just merging the PR's defaults. It's easiest to just see the resulting upgrade PRs, form an opinion on what you like/don't like, and tweak the config based on that.

@afonsojramos
Copy link
Member Author

I would have done it already, but unfortunately I only have write access for now, not admin access. Hopefully this can change in the future as having just one admin can be a blocker too often.

@bmulholland
Copy link
Collaborator

Oh, yeah, well that's that then :)

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or enhancement to existing functionality

Development

Successfully merging this pull request may close these issues.

3 participants