Skip to content

feat: Hide app's dock icon #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 11, 2020
Merged

feat: Hide app's dock icon #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd13e3c
feat: Hide app's dock icon
manosim Dec 11, 2020
edf443b
chore: Apply prettier
manosim Dec 11, 2020
7f1b33d
chore: Delay calling app.dock.hide
manosim Dec 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions first-run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,4 @@ function isFirstRun() {
return true;
}

module.exports = { onFirstRunMaybe }

module.exports = { onFirstRunMaybe };
19 changes: 17 additions & 2 deletions main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@ const { autoUpdater } = require('electron-updater');
const { onFirstRunMaybe } = require('./first-run');
const path = require('path');

const iconIdle = path.join(__dirname, 'assets', 'images', 'tray-idleTemplate.png');
const iconIdle = path.join(
__dirname,
'assets',
'images',
'tray-idleTemplate.png'
);
const iconActive = path.join(__dirname, 'assets', 'images', 'tray-active.png');

const browserWindowOpts = {
Expand All @@ -17,12 +22,20 @@ const browserWindowOpts = {
enableRemoteModule: true,
overlayScrollbars: true,
nodeIntegration: true,
contextIsolation: false,
},
};

const delayedHideAppIcon = () =>
// Setting a timeout because the showDockIcon is not currently working
// See more at https://github.com/maxogden/menubar/issues/306
setTimeout(() => {
app.dock.hide();
}, 1500);

app.on('ready', async () => {
await onFirstRunMaybe();
})
});

const menubarApp = menubar({
icon: iconIdle,
Expand All @@ -32,6 +45,8 @@ const menubarApp = menubar({
});

menubarApp.on('ready', () => {
delayedHideAppIcon();

menubarApp.tray.setIgnoreDoubleClickEvents(true);

autoUpdater.checkForUpdatesAndNotify();
Expand Down