Raise test coverage to 100% #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manosim
requested changes
May 2, 2020
src/js/store/configureStore.ts
Outdated
| storageMiddleware, | ||
| ]; | ||
|
|
||
| /* istanbul ignore next */ |
There was a problem hiding this comment.
Might not be related to this PR - but shall we remove this block completely (along with the isDev variable)? I guess we can also remove redux-logger from package.json.
There was a problem hiding this comment.
Awesome! Even better 😎, I'll make this change.
I didn't want to overstep and really tried to avoid changing non-test files, but if you'd be okay with refactors, I'd be happy to go deeper and propose some cleanup changes.
|
|
||
| exports[`./utils/github-api.ts should format the notification reason 12`] = ` | ||
| Object { | ||
| "description": undefined, |
There was a problem hiding this comment.
Just realised that this is broken in the source file - shall we update the actual file https://github.com/manosim/gitify/blob/master/src/js/utils/github-api.ts#L48 to use DESCRIPTIONS['CI_ACTIVITY'] which will remove that undefined.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This raises the line-by-line test coverage from 98% to 100%. I tried to keep my edits limited to only the tests, with the exception of
src/js/store/configureStore.tshaving a block of code that looks like it exists for debugging/development.