Skip to content

Build PRs without codesign-ing #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Build PRs without codesign-ing #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3d1447
Don't codesign for PRs
manosim Feb 20, 2020
c7468ad
Tests: Mock date for snapshot
manosim Feb 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
env:
CSC_LINK: ${{ secrets.mac_certs }}
CSC_KEY_PASSWORD: ${{ secrets.mac_certs_password }}
run: yarn make:macos
run: yarn make:macos -c.mac.identity=null

- name: Clean up builds
run: rm -rfv dist/mac
Expand Down
2 changes: 1 addition & 1 deletion src/js/components/__snapshots__/notification.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ exports[`components/notification.js should render itself & its children 1`] = `
</span>
- Updated

over 2 years ago
in over 3 years
</div>
</div>
<div
Expand Down
2 changes: 2 additions & 0 deletions src/js/components/notification.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ describe('components/notification.js', () => {
});

it('should render itself & its children', async () => {
(global as any).Date.now = jest.fn(() => new Date('2014'));

const props = {
markNotification: jest.fn(),
markOnClick: false,
Expand Down