feat: working electron-vite config #2227
Draft
+1,634
−3,486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependency
|
bmulholland
reviewed
Sep 15, 2025
| @import "@primer/css/dist/primer.css"; | ||
|
|
||
| /** Tailwind CSS Configuration */ | ||
| @config '../../tailwind.config.ts'; |
There was a problem hiding this comment.
It it possible to make the tailwind change separately, to reduce complexity and risk for both vite and tailwind changes?
|
I have a working project with electron-vite in use. I'm not super experienced with it, but may be able to help if you run into something tricky. |
The goal was to simply simplify the project as webpack does present its challenges, so hopefully less tricky things will appear 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request migrates the Electron app's build system from Webpack to electron-vite, resulting in a significant simplification of the configuration files and build scripts. It removes all Webpack-related configuration and dependencies, introduces new vite-based configuration, and updates file paths and environment variable handling throughout the codebase. Additionally, the CSS and asset handling are modernized to work with Vite and Tailwind v4 (no need for a config file), and logger usage is improved for better compatibility between main and renderer processes.
At the current state however, Primer's variables are being loaded, but somehow not used yet.