Skip to content

feat(filters): search by org, repo, author #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Sep 9, 2025
Merged

feat(filters): search by org, repo, author #2214

merged 30 commits into from
Sep 9, 2025

Conversation

setchy
Copy link
Member

@setchy setchy commented Sep 6, 2025 •
edited
Loading

2025-09-08T14-07-24 821Z-Gitify-screenshot

Closes #2192

@setchy
Copy link
Member Author

setchy commented Sep 6, 2025

Still a bit more tidy up required on the code...

@setchy setchy changed the title [WIP] feat(filters): search by org, repo, author feat(filters): search by org, repo, author Sep 8, 2025
@github-actions github-actions bot added the enhancement New feature or enhancement to existing functionality label Sep 8, 2025
@setchy setchy marked this pull request as ready for review September 8, 2025 16:03
@setchy setchy mentioned this pull request Sep 8, 2025
Closed
@vallieres
Copy link
Contributor

@setchy Not sure if it's linked to your changes, I've build it from your PR and when I try to add my PAT I get this:

08:49:39.599 " [loginWithPersonalAccessToken] Failed to login with PAT Error: Error invoking remote method 'gitify:safe-storage-decrypt': Error: Error while decrypting the ciphertext provided to safeStorage.decryptString. Ciphertext does not appear to be encrypted.
[66861:0909/084939.601635:INFO:CONSOLE:71263] "08:49:39.599 " [loginWithPersonalAccessToken] Failed to login with PAT Error: Error invoking remote method 'gitify:safe-storage-decrypt': Error: Error while decrypting the ciphertext provided to safeStorage.decryptString. Ciphertext does not appear to be encrypted.", source: file:///Volumes/.../gitify/build/renderer.js (71263)

And I get the red error on the UI.

@setchy
Copy link
Member Author

setchy commented Sep 9, 2025

@vallieres - great catch - it's unrelated, but a confirmed bug on main. I'll have a fix ready shortly...

@setchy
Copy link
Member Author

setchy commented Sep 9, 2025

@vallieres - this branch should be good to re-test now

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vallieres
vallieres approved these changes Sep 9, 2025
View reviewed changes
Copy link
Contributor

@vallieres vallieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Great change! I love how the tooltip shows when you are typing in the field.
👩‍🍳💋

@setchy setchy merged commit 3ddbb78 into main Sep 9, 2025
14 checks passed
@setchy setchy deleted the feat/filter-search branch September 9, 2025 23:57
@github-actions github-actions bot added this to the Release 6.8.0 milestone Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

1 more reviewer

@vallieres vallieres vallieres approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement New feature or enhancement to existing functionality
Milestone
Release 6.8.0
Development

Successfully merging this pull request may close these issues.

Filter by repository name
3 participants
@setchy @vallieres @Copilot