Skip to content

fix: set 'Cache-Control: no-cache' for GHE server #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix: set 'Cache-Control: no-cache' for GHE server #1622

merged 1 commit into from
Nov 5, 2024

Conversation

pddg
Copy link
Contributor

@pddg pddg commented Nov 5, 2024

fix #1611

Whether it is github.com or GHE Server, set the Cache-Control: no-cache header.

@pddg
Set 'Cache-Control: no-cache' for not only github.com but also GitHub…
1d9941a 
… Enterprise Server.

GitHub Enterprise Server has URL paths which is different from github.com.
@pddg pddg mentioned this pull request Nov 5, 2024
Closed
1 task
@setchy setchy changed the title Set 'Cache-Control: no-cache' for GHE server fix: set 'Cache-Control: no-cache' for GHE server Nov 5, 2024
@setchy setchy added host:github-server Related to GitHub Enterprise Server bug Something isn't working labels Nov 5, 2024
setchy
setchy approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@setchy setchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great fix!

@setchy setchy merged commit 71a5714 into gitify-app:main Nov 5, 2024
9 of 12 checks passed
@pddg pddg deleted the fix-issue-1611 branch November 5, 2024 00:44
@setchy setchy added this to the Release 5.16.2 milestone Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@setchy setchy setchy approved these changes

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees
No one assigned
Labels
bug Something isn't working host:github-server Related to GitHub Enterprise Server
Milestone
Release 5.16.2
Development

Successfully merging this pull request may close these issues.

Gitify displays the same notification repeatedly when using GHE Server
2 participants
@pddg @setchy