Skip to content

refactor: use sentence case for interaction #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2024
Merged

refactor: use sentence case for interaction #1558

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c85b23c
refactor: rename `Done` and `Read` to `done` and `read`
setchy Sep 27, 2024
a0aa87c
refactor: mark repository sentence case
setchy Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/NotificationRow.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ describe('components/NotificationRow.tsx', () => {
</AppContext.Provider>,
);

fireEvent.click(screen.getByTitle('Mark as Read'));
fireEvent.click(screen.getByTitle('Mark as read'));
expect(markNotificationRead).toHaveBeenCalledTimes(1);
});

Expand All @@ -224,7 +224,7 @@ describe('components/NotificationRow.tsx', () => {
</AppContext.Provider>,
);

fireEvent.click(screen.getByTitle('Mark as Done'));
fireEvent.click(screen.getByTitle('Mark as done'));
expect(markNotificationDone).toHaveBeenCalledTimes(1);
});

Expand Down
4 changes: 2 additions & 2 deletions src/components/NotificationRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export const NotificationRow: FC<INotificationRow> = ({
<HoverGroup>
{isMarkAsDoneFeatureSupported(notification.account) && (
<InteractionButton
title="Mark as Done"
title="Mark as done"
icon={CheckIcon}
size={Size.MEDIUM}
onClick={() => {
Expand All @@ -142,7 +142,7 @@ export const NotificationRow: FC<INotificationRow> = ({
/>
)}
<InteractionButton
title="Mark as Read"
title="Mark as read"
icon={ReadIcon}
size={Size.SMALL}
onClick={() => {
Expand Down
32 changes: 16 additions & 16 deletions src/components/__snapshots__/AccountNotifications.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

48 changes: 24 additions & 24 deletions src/components/__snapshots__/NotificationRow.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/components/settings/NotificationSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export const NotificationSettings: FC = () => {
}
tooltip={
<div>
<strong>Mark as Done</strong> feature is supported in GitHub Cloud
<strong>Mark as done</strong> feature is supported in GitHub Cloud
and GitHub Enterprise Server 3.13 or later.
</div>
}
Expand All @@ -92,7 +92,7 @@ export const NotificationSettings: FC = () => {
}
tooltip={
<div>
<strong>Mark as Done</strong> feature is supported in GitHub Cloud
<strong>Mark as done</strong> feature is supported in GitHub Cloud
and GitHub Enterprise Server 3.13 or later.
</div>
}
Expand Down
2 changes: 1 addition & 1 deletion src/utils/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export function isEnterpriseServerHost(hostname: Hostname): boolean {

export function isMarkAsDoneFeatureSupported(account: Account): boolean {
if (isEnterpriseServerHost(account.hostname)) {
// Support for "Mark as Done" was added to GitHub Enterprise Server in v3.13 or newer
// Support for "Mark as done" was added to GitHub Enterprise Server in v3.13 or newer
if (account.version) {
const version = account?.version.split('.').map(Number);
return version[0] >= 3 && version[1] >= 13;
Expand Down