Skip to content

refactor: extract error constants #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2024
Merged

refactor: extract error constants #1506

merged 1 commit into from
Sep 2, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Sep 2, 2024 •
edited
Loading

goal is to slowly working towards separating the gitify specific constants/types from the github (or other platform) constants/types

@setchy setchy added this to the Release 5.14.0 milestone Sep 2, 2024
@github-actions github-actions bot added the refactor Refactoring of existing feature label Sep 2, 2024
bmulholland
bmulholland approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup :)

@setchy setchy merged commit d304858 into main Sep 2, 2024
15 checks passed
@setchy setchy deleted the refactor/extract-error-constants branch September 2, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmulholland bmulholland bmulholland approved these changes

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

Assignees
No one assigned
Labels
refactor Refactoring of existing feature
Milestone
Release 5.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@setchy @bmulholland