Skip to content

feat: hide hover groups on transition #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2024
Merged

feat: hide hover groups on transition #1427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 30 additions & 28 deletions src/components/NotificationRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,34 +124,36 @@ export const NotificationRow: FC<INotificationRow> = ({
<NotificationFooter notification={notification} />
</div>

<HoverGroup>
<InteractionButton
title="Mark as Done"
icon={CheckIcon}
size={Size.MEDIUM}
onClick={() => {
setAnimateExit(!settings.delayNotificationState);
setShowAsRead(settings.delayNotificationState);
markNotificationDone(notification);
}}
/>
<InteractionButton
title="Mark as Read"
icon={ReadIcon}
size={Size.SMALL}
onClick={() => {
setAnimateExit(!settings.delayNotificationState);
setShowAsRead(settings.delayNotificationState);
markNotificationRead(notification);
}}
/>
<InteractionButton
title="Unsubscribe from Thread"
icon={BellSlashIcon}
size={Size.SMALL}
onClick={unsubscribeFromThread}
/>
</HoverGroup>
{!animateExit && (
<HoverGroup>
<InteractionButton
title="Mark as Done"
icon={CheckIcon}
size={Size.MEDIUM}
onClick={() => {
setAnimateExit(!settings.delayNotificationState);
setShowAsRead(settings.delayNotificationState);
markNotificationDone(notification);
}}
/>
<InteractionButton
title="Mark as Read"
icon={ReadIcon}
size={Size.SMALL}
onClick={() => {
setAnimateExit(!settings.delayNotificationState);
setShowAsRead(settings.delayNotificationState);
markNotificationRead(notification);
}}
/>
<InteractionButton
title="Unsubscribe from Thread"
icon={BellSlashIcon}
size={Size.SMALL}
onClick={unsubscribeFromThread}
/>
</HoverGroup>
)}
</div>
);
};
66 changes: 34 additions & 32 deletions src/components/RepositoryNotifications.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,38 +78,40 @@ export const RepositoryNotifications: FC<IRepositoryNotifications> = ({
</span>
</div>

<HoverGroup>
<InteractionButton
title="Mark Repository as Done"
icon={CheckIcon}
size={Size.MEDIUM}
onClick={(event: MouseEvent<HTMLElement>) => {
// Don't trigger onClick of parent element.
event.stopPropagation();
setAnimateExit(!settings.delayNotificationState);
setShowAsRead(settings.delayNotificationState);
markRepoNotificationsDone(repoNotifications[0]);
}}
/>
<InteractionButton
title="Mark Repository as Read"
icon={ReadIcon}
size={Size.SMALL}
onClick={(event: MouseEvent<HTMLElement>) => {
// Don't trigger onClick of parent element.
event.stopPropagation();
setAnimateExit(!settings.delayNotificationState);
setShowAsRead(settings.delayNotificationState);
markRepoNotificationsRead(repoNotifications[0]);
}}
/>
<InteractionButton
title={toggleRepositoryNotificationsLabel}
icon={ChevronIcon}
size={Size.SMALL}
onClick={toggleRepositoryNotifications}
/>
</HoverGroup>
{!animateExit && (
<HoverGroup>
<InteractionButton
title="Mark Repository as Done"
icon={CheckIcon}
size={Size.MEDIUM}
onClick={(event: MouseEvent<HTMLElement>) => {
// Don't trigger onClick of parent element.
event.stopPropagation();
setAnimateExit(!settings.delayNotificationState);
setShowAsRead(settings.delayNotificationState);
markRepoNotificationsDone(repoNotifications[0]);
}}
/>
<InteractionButton
title="Mark Repository as Read"
icon={ReadIcon}
size={Size.SMALL}
onClick={(event: MouseEvent<HTMLElement>) => {
// Don't trigger onClick of parent element.
event.stopPropagation();
setAnimateExit(!settings.delayNotificationState);
setShowAsRead(settings.delayNotificationState);
markRepoNotificationsRead(repoNotifications[0]);
}}
/>
<InteractionButton
title={toggleRepositoryNotificationsLabel}
icon={ChevronIcon}
size={Size.SMALL}
onClick={toggleRepositoryNotifications}
/>
</HoverGroup>
)}
</div>

{showRepositoryNotifications &&
Expand Down