Skip to content

feat: use custom hostname on Sidebar link #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: use custom hostname on Sidebar link #1422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/components/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,17 @@ export const Sidebar: FC = () => {
const navigate = useNavigate();
const location = useLocation();

const { notifications, fetchNotifications, isLoggedIn, status, settings } =
useContext(AppContext);
const {
auth,
notifications,
fetchNotifications,
isLoggedIn,
status,
settings,
} = useContext(AppContext);

const isSingleAccount = auth?.accounts.length === 1;
const account = isSingleAccount ? auth?.accounts[0] : undefined;

const toggleFilters = () => {
if (location.pathname.startsWith('/filters')) {
Expand Down Expand Up @@ -77,19 +86,19 @@ export const Sidebar: FC = () => {
title={`${notificationsCount} Unread Notifications`}
metric={notificationsCount}
icon={BellIcon}
onClick={() => openGitHubNotifications()}
onClick={() => openGitHubNotifications(account)}
/>

<SidebarButton
title="My Issues"
icon={IssueOpenedIcon}
onClick={() => openGitHubIssues()}
onClick={() => openGitHubIssues(account)}
/>

<SidebarButton
title="My Pull Requests"
icon={GitPullRequestIcon}
onClick={() => openGitHubPulls()}
onClick={() => openGitHubPulls(account)}
/>
</div>

Expand Down
15 changes: 9 additions & 6 deletions src/utils/links.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,19 @@ export function openGitifyReleaseNotes(version: string) {
);
}

export function openGitHubNotifications() {
openExternalLink('https://github.com/notifications' as Link);
export function openGitHubNotifications(account?: Account) {
const hostname = account?.hostname || Constants.DEFAULT_AUTH_OPTIONS.hostname;
openExternalLink(`https://${hostname}/notifications` as Link);
}

export function openGitHubIssues() {
openExternalLink('https://github.com/issues' as Link);
export function openGitHubIssues(account?: Account) {
const hostname = account?.hostname || Constants.DEFAULT_AUTH_OPTIONS.hostname;
openExternalLink(`https://${hostname}/issues` as Link);
}

export function openGitHubPulls() {
openExternalLink('https://github.com/pulls' as Link);
export function openGitHubPulls(account?: Account) {
const hostname = account?.hostname || Constants.DEFAULT_AUTH_OPTIONS.hostname;
openExternalLink(`https://${hostname}/pulls` as Link);
}

export function openAccountProfile(account: Account) {
Expand Down