Skip to content

Conversation

setchy
Copy link
Member

@setchy setchy commented Jul 28, 2024

No description provided.

@setchy setchy added this to the Release 5.12.0 milestone Jul 28, 2024
@setchy setchy changed the title fix/lint-warning chore: fix lint warning Jul 28, 2024
@setchy setchy changed the title chore: fix lint warning fix: biomejs lint warning Jul 28, 2024
@setchy setchy changed the title fix: biomejs lint warning refactor: fix biomejs lint warning Jul 28, 2024
@github-actions github-actions bot added bug Something isn't working refactor Refactoring of existing feature and removed bug Something isn't working labels Jul 28, 2024
@setchy setchy merged commit 7e4aea7 into main Jul 29, 2024
@setchy setchy deleted the fix/lint-error branch July 29, 2024 13:54
setSettings(newSettings);
saveState({ auth, settings: newSettings });
}, [auth]);
}, [auth, settings]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful with this 👀 All linters are known for sometimes inducing people in error with this, for example in useEffects

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. So for this instance do you think this should be reverted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactoring of existing feature

Development

Successfully merging this pull request may close these issues.

3 participants