Skip to content

feat: align filters by using legend component #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2024
Merged

feat: align filters by using legend component #1344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/routes/Filters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
import { type FC, useContext } from 'react';
import { Header } from '../components/Header';
import { Checkbox } from '../components/fields/Checkbox';
import { Legend } from '../components/settings/Legend';
import { AppContext } from '../context/App';
import { BUTTON_CLASS_NAME } from '../styles/gitify';
import { Size } from '../types';
Expand Down Expand Up @@ -36,10 +37,7 @@ export const FiltersRoute: FC = () => {
<Header fetchOnBack={true}>Filters</Header>
<div className="flex-grow overflow-x-auto px-8">
<fieldset className="mb-3">
<legend id="notifications" className="mb-1 mt-2 font-semibold">
<FeedPersonIcon className="mr-2" />
Users
</legend>
<Legend icon={FeedPersonIcon}>Users</Legend>
<Checkbox
name="hideBots"
label="Hide notifications from Bot accounts"
Expand All @@ -65,10 +63,7 @@ export const FiltersRoute: FC = () => {
</fieldset>

<fieldset className="mb-3">
<legend id="appearance" className="mb-1 mt-2 font-semibold">
<NoteIcon className="mr-2" />
Reason
</legend>
<Legend icon={NoteIcon}>Reason</Legend>
<span className="text-xs italic">
Note: if no reasons are selected, all notifications will be shown.
</span>
Expand Down
8 changes: 4 additions & 4 deletions src/routes/__snapshots__/Filters.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.