fix: regression in delay notification state behavior #1241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the regression exactly? Does this not remove the notification before the animation ends? I opted for this approach because of that. Maybe I should have asked that on the pr 😅 |
|
The regression is the row doesn't get set as opaque and left until the next refresh interval. Instead, it's removed but left with a blank gap/void. Particularly noticeable when you interact with the last notification for a repository as it leaves the repository heading with a void below it UPDATE: added recording to the OP |
|
Happy to hear if there is a better way 😎 |
afonsojramos
requested changes
Jun 16, 2024
afonsojramos
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix regression issue from #1232 when using
delayNotificationStatesetting.Before
Screen.Recording.2024-06-15.at.1.50.03.PM.mov
After
Screen.Recording.2024-06-15.at.1.52.53.PM.mov