Skip to content

style: cleanup useless tw classnames #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2024
Merged

style: cleanup useless tw classnames #1238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e4dfd5
style: cleanup useless tw classnames
afonsojramos Jun 14, 2024
8e2d814
fix: oops regression
afonsojramos Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!doctype html>
<!DOCTYPE html>
<html lang="en">
<head>
<title>Gitify</title>
Expand All @@ -9,30 +9,30 @@
</head>

<body>
<div id="gitify"></div>
<div
id="gitify"
class="bg-white text-black dark:bg-gray-dark dark:text-white"
></div>
</body>

<script src="./build/js/app.js"></script>

<style>
html,
body {
body,
#gitify {
height: 100%;
-webkit-user-select: none;
}

body {
font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', 'Roboto',
'Oxygen', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans',
'Helvetica Neue', sans-serif;
font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto",
"Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans",
"Helvetica Neue", sans-serif;
margin: 0;
cursor: default;
}

#gitify {
height: 100%;
}

#nprogress {
pointer-events: none;
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/AllRead.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export const AllRead = () => {
);

return (
<div className="flex flex-1 flex-col items-center justify-center bg-white p-4 text-black dark:bg-gray-dark dark:text-white">
<div className="flex flex-col items-center justify-center bg-white p-4 text-black dark:bg-gray-dark dark:text-white">
<h1 className="mb-5 text-5xl">{emoji}</h1>

<h2 className="mb-2 text-xl font-semibold">No new notifications.</h2>
Expand Down
2 changes: 1 addition & 1 deletion src/components/Oops.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export const Oops: FC<IProps> = ({ error }) => {
);

return (
<div className="flex flex-1 flex-col items-center justify-center bg-white p-4 text-black dark:bg-gray-dark dark:text-white">
<div className="flex flex-1 flex-col items-center justify-center p-4">
<h1 className="mb-5 text-5xl">{emoji}</h1>

<h2 className="mb-2 text-xl font-semibold">{error.title}</h2>
Expand Down
4 changes: 2 additions & 2 deletions src/components/__snapshots__/AllRead.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/components/__snapshots__/Oops.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/components/fields/FieldInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const FieldInput: FC<IFieldInput> = ({
{({ input, meta: { touched, error } }) => (
<div className="mb-4">
<label
className="mb-2 block text-sm font-semibold tracking-wide text-gray-dark"
className="mb-2 block text-sm font-semibold tracking-wide"
htmlFor={input.name}
>
{label}
Expand Down
4 changes: 2 additions & 2 deletions src/components/fields/__snapshots__/FieldInput.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 2 additions & 5 deletions src/routes/Accounts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,7 @@ export const AccountsRoute: FC = () => {
}, []);

return (
<div
className="flex h-screen flex-1 flex-col dark:bg-gray-dark dark:text-white"
data-testid="accounts"
>
<div className="flex h-screen flex-col" data-testid="accounts">
<div className="mx-8 mt-2 flex items-center justify-between py-2">
<button
type="button"
Expand All @@ -72,7 +69,7 @@ export const AccountsRoute: FC = () => {
{auth.accounts.map((account) => (
<div
key={getAccountUUID(account)}
className="mb-4 flex items-center justify-between rounded-md bg-gray-100 p-1 dark:bg-gray-900"
className="mb-4 flex items-center justify-between rounded-md bg-gray-100 p-2 dark:bg-gray-sidebar"
>
<div className="ml-2 text-xs">
<div>
Expand Down
2 changes: 1 addition & 1 deletion src/routes/Login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const LoginRoute: FC = () => {
}, []); */

return (
<div className="flex flex-1 flex-col items-center justify-center bg-white p-4 dark:bg-gray-dark dark:text-white">
<div className="flex flex-col items-center justify-center p-4">
<Logo className="h-16 w-16" isDark />

<div className="my-4 px-2.5 py-1.5 text-center font-semibold">
Expand Down
4 changes: 2 additions & 2 deletions src/routes/LoginWithOAuthApp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export const LoginWithOAuthApp: FC = () => {
);

return (
<div className="flex-1 bg-white dark:bg-gray-dark dark:text-white">
<div>
<div className="mx-8 mt-4 flex items-center justify-between py-2">
<button
type="button"
Expand All @@ -150,7 +150,7 @@ export const LoginWithOAuthApp: FC = () => {
</h3>
</div>

<div className="flex-1 px-8">
<div className="px-8">
<Form
initialValues={{
hostname: '',
Expand Down
4 changes: 2 additions & 2 deletions src/routes/LoginWithPersonalAccessToken.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export const LoginWithPersonalAccessToken: FC = () => {
);

return (
<div className="flex-1 bg-white dark:bg-gray-dark dark:text-white">
<div>
<div className="mx-8 mt-4 flex items-center justify-between py-2">
<button
type="button"
Expand All @@ -158,7 +158,7 @@ export const LoginWithPersonalAccessToken: FC = () => {
</h3>
</div>

<div className="flex-1 px-8">
<div className="px-8">
<Form
initialValues={{
hostname: Constants.DEFAULT_AUTH_OPTIONS.hostname,
Expand Down
2 changes: 1 addition & 1 deletion src/routes/Notifications.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const NotificationsRoute: FC = () => {
}

return (
<div className="flex flex-1 flex-col bg-white dark:bg-gray-dark">
<div className="flex flex-col">
{notifications.map((accountNotifications) => (
<AccountNotifications
key={getAccountUUID(accountNotifications.account)}
Expand Down
5 changes: 1 addition & 4 deletions src/routes/Settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,7 @@ export const SettingsRoute: FC = () => {
}, [settings.theme]);

return (
<div
className="flex h-screen flex-1 flex-col dark:bg-gray-dark dark:text-white"
data-testid="settings"
>
<div className="flex h-screen flex-col" data-testid="settings">
<div className="mx-8 mt-2 flex items-center justify-between py-2">
<button
type="button"
Expand Down
8 changes: 4 additions & 4 deletions src/routes/__snapshots__/Accounts.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/routes/__snapshots__/Login.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 10 additions & 14 deletions src/routes/__snapshots__/LoginWithOAuthApp.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading