build: husky run all tests #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmulholland
approved these changes
Apr 11, 2024
|
I suppose that since our codebase is quite small, it doesn't really make a big difference,. otherwise I'd suggest the other route |
|
Agree, can adjust as we grow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since enabling
collectCoverageby default, husky will routinely fail since the changes files do not cover the test cases to get a correct coverage gating measure.Changing to run all tests as part of the husky pre-commit hook. I think this OK.
Alternatively, if we want to continue running on changes files only, we could disable the coverage check
pnpm test -- --onlyChanged --collectCoverage=false