Multiselect on categories

[nikodraca]

It would be great if you could multiselect values on category fields. Currently you can only select one category to filter on.

Any interest in this? I don't mind taking a crack at it.

[Wattenberger]

we would definitely be open to a PR on this, thanks!

[nikodraca]

@Wattenberger would you be able to give me permissions to make PRs 🙏?

[Wattenberger]

@nikodraca do you mind forking the repo and creating a PR from there? Similar to this PR:
#10

[nikodraca]

@Wattenberger revisiting this now that I have a better understanding of the codebase - I think the first item of work is multiselect on category fields. I believe this will be doable with Downshift (though I don't have any experience with it).

The second item of work, which I think requires a larger discussion, is about filtering on array fields:

• is filtering by array fields a feature you/others would want? Personally I have a use case where I'd like to be able to filter on multiple items of an array (ie. give me all rows where the array includes X or Y)
• is there a reason to display X item(s) in the cell vs something like a stringified array for array fields?
• I can't quite figure out the difference between a short-array and array, could you explain this to me?

Excited to contribute 😄

[Wattenberger]

is filtering by array fields a feature you/others would want? Personally I have a use case where I'd like to be able to filter on multiple items of an array (ie. give me all rows where the array includes X or Y)

I bet we'll be able to add multiselect in a way that doesn't detract from the single-select use case. If so, I bet a lot of people would find it useful!

is there a reason to display X item(s) in the cell vs something like a stringified array for array fields?
I can't quite figure out the difference between a short-array and array, could you explain this to me?

I think these questions are related. We're differentiating between columns where the contents are usually one item in an array (short-array) and other arrays (array). This is so we can display shorter array values in a more readable fashion, whereas longer arrays are potentially easier to "read" & compare if we just display the number of items in each array.
https://github.com/githubocto/flat-ui/blob/main/src/store.ts#L813-L831

Let me know if any of that didn't make sense!

[nikodraca]

So if I understand correctly the idea was that arrays really meant to be filtered by length and less by the contents?

Follow up q: couldn't we consolidate categories and short-arrays?

[Wattenberger]

hmm, potentially. They wouldn't automatically be categories, but could be passed further down and treated the same as columns of strings: https://github.com/githubocto/flat-ui/blob/main/src/store.ts#L688

I'm a bit hesitant to do more "magic" handling of data, though! The farther we get from the raw data, the less reliable the table view gets. There is the possibility to treat items within array values are rendered as pills, similar to category values, which is perhaps what you're getting at. In that case, I think the path forward would be to have a multiselect filter, and to change the render component for arrays.

[nikodraca]

Ok cool, thanks for answering all my questions 😄

[nikodraca]

Hey @Wattenberger 👋 wanted to share some progress and get some feedback:
https://user-images.githubusercontent.com/3537270/154796985-ab232baa-1a24-4cef-991b-7c06208c6794.mov

What's New:

• Categories filters are now arrays
• Input is now multiselect (using Downshift's useMultipleSelection
• Column header shows current selection with option to remove

Questions:

• Wasn't sure what the UX for displaying/removing current selection should be. I opted for displaying them in a row and making that scrollable. Any thoughts on this?
• You might notice in the screencast that when filtering on the second category it shows the count as 0 (cool (0)). This is because a row can only have 1 category, but category filters apply to the entire dataset, not just the filtered subset. I'm thinking of instead counting how many rows have that category from originalData instead of filteredData. Does that make sense?

[nikodraca]

Hey @Wattenberger 😄 just wanted to check in on this, really eager to get the ball rolling!

[nikodraca]

Hey @Wattenberger sorry to bother again, I'd love to get some eyes on this! Is there someone on the team you could put me in touch with?