Skip to content

Experimental: Check for override attribute disable-preference-override #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Experimental: Check for override attribute disable-preference-override #331

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4e0921
when determining if we should display user time preferences, check fo…
zaataylor Nov 6, 2025
e454842
Rename attribute for user time preference override
zaataylor Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/relative-time-element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,9 @@ export class RelativeTimeElement extends HTMLElement implements Intl.DateTimeFor
// Never override duration format with absolute format.
if (format === 'duration') return false

// Override for user preferences; used sparingly to preserve intended relative formatting in some places
if (this.hasAttribute('disable-preference-override')) return false

return (
this.ownerDocument.documentElement.getAttribute('data-prefers-absolute-time') === 'true' ||
this.ownerDocument.body?.getAttribute('data-prefers-absolute-time') === 'true'
Expand Down