Skip to content

Conversation

@cjmartian
Copy link
Contributor

Overview

This pull request reduces the puppet/ruby matrix for our CI.

Checklist

  • Make sure that all of the tests pass, and fix any that don't. Just run rake in your checkout directory, or review the CI job triggered whenever you push to a pull request.
  • Make sure that there is 100% test coverage by running rake coverage:spec or ignoring untestable sections of code with # :nocov comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests.
  • If you have added a new command line option, we would greatly appreciate a corresponding integration test that exercises it from start to finish. This is optional but recommended.
  • If you have added any new gem dependencies, make sure those gems are licensed under the MIT or Apache 2.0 license. We cannot add any dependencies on gems licensed under GPL.
  • If you have added any new gem dependencies, make sure you've checked in a copy of the .gem file into the vendor/cache directory.

/cc [related issues] [teams and individuals, making sure to mention why you're CC-ing them]

@cjmartian cjmartian self-assigned this Jan 24, 2024
@cjmartian cjmartian force-pushed the clean-ci branch 6 times, most recently from ff1514a to eef2f16 Compare January 24, 2024 21:26
Copy link
Contributor

@jhongturney jhongturney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping this updated 👍🏻

@cjmartian cjmartian merged commit 8abad34 into github:master Jan 24, 2024
@cjmartian cjmartian deleted the clean-ci branch January 24, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants