Handle JSON facts structured as name/values #242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request allows JSON facts to come in the following format without double-encoding them. You can get facts structured like this by running
puppet facts find $(hostname):{ "name":"rspec-node.abc.github.net", "values":{ "apt_update_last_success":1458162123, "architecture":"amd64", "datacenter":"xyz", "fqdn":"rspec-node.xyz.github.net", "_timestamp":"2014-12-02 14:56:20 -0600" } }The YAML fact handler already had logic that dealt with this case, but the JSON handler didn't. So if you submitted the above JSON file in
--fact-fileit would end up double-encoding them internally:{ "name":"unknown.node", "values":{ "name": "rspec-node.abc.github.net", "values":{ "apt_update_last_success":1458162123, "architecture":"amd64", "datacenter":"xyz", "fqdn":"rspec-node.xyz.github.net", "_timestamp":"2014-12-02 14:56:20 -0600" } } }Checklist
rakein your checkout directory, or review the CI job triggered whenever you push to a pull request.rake coverage:specor ignoring untestable sections of code with# :nocovcomments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests..gemfile into the vendor/cache directory.