Try again #219
Merged
Try again #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use a docker-based workflow to get consistent runs. Note that we use stretch images for newer ruby versions and do some ssl hackery - more recent debian versions see SSL test failures related to unsupported ciphers, etc. Rather than debug them now, we ignore them - they're not likely related directly to the code we're testing. We also hack up the ruby docker image; because they do this strange thing where they install gems globally into one bundle. It messes up this build process, so we undo it to the best of our ability.
ahayworth
force-pushed
the
ahayworth-patch-1
branch
from
3235095 to
8cf9abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR successfully reworks the CI suite to run in containers on GitHub Actions.