Add Support for Hashdiff 1.0.0 #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Hashdiff version 1.0.0, octocatalog-diff failed with the following error: `uninitialized constant OctocatalogDiff::CatalogDiff::Differ::HashDiff (NameError)` Hashdiff 1.0.0 was released on July, 15 2019 and replaced the constant "HashDiff" with "Hashdiff". This commit fixes this error and keeps octocatalog-diff backwards compatible to older versions of HashDiff.
speer
force-pushed
the
fix-compatibility-issue-hashdiff-1.0.0
branch
from
8f30cfa to
1ce938e
Compare
|
I need this fix as well. |
isaiahfrantz
approved these changes
Oct 1, 2019
ahayworth
approved these changes
Oct 28, 2019
Contributor
ahayworth
left a comment
ahayworth
left a comment
There was a problem hiding this comment.
This looks reasonable to me. We'll target this for 1.6.0 later this week, unless internal testing shows something unexpected.
Thank you for your patience, I know nothing has happened on this repo for awhile. ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces support for Hashdiff version 1.0.0.
When using Hashdiff version 1.0.0, octocatalog-diff failed with the following error:
uninitialized constant OctocatalogDiff::CatalogDiff::Differ::HashDiff (NameError).See also: liufengyun/hashdiff#45
Hashdiff 1.0.0 was released on July, 15 2019 and replaced the constant "HashDiff" with "Hashdiff".
This commit fixes this error and keeps octocatalog-diff backwards compatible to older versions
of HashDiff.
Checklist
rakein your checkout directory, or review the CI job triggered whenever you push to a pull request.rake coverage:specor ignoring untestable sections of code with# :nocovcomments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests..gemfile into the vendor/cache directory.