Skip to content

Conversation

@kpaulisse
Copy link
Contributor

Overview

This pull request bumps many of the dependency gems to updated versions. The default version of Puppet is also changed to 5.5.3 for the tests.

Checklist

  • Make sure that all of the tests pass, and fix any that don't. Just run rake in your checkout directory, or review the CI job triggered whenever you push to a pull request.
  • Make sure that there is 100% test coverage by running rake coverage:spec or ignoring untestable sections of code with # :nocov comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests.
  • If you have added a new command line option, we would greatly appreciate a corresponding integration test that exercises it from start to finish. This is optional but recommended.
  • If you have added any new gem dependencies, make sure those gems are licensed under the MIT or Apache 2.0 license. We cannot add any dependencies on gems licensed under GPL.
  • If you have added any new gem dependencies, make sure you've checked in a copy of the .gem file into the vendor/cache directory.

@kpaulisse kpaulisse mentioned this pull request Dec 7, 2018
@kpaulisse
Copy link
Contributor Author

CI passes, and I see everyone having to implement this fix in their branches, so I'm going to merge it...

@kpaulisse kpaulisse merged commit ea513b6 into master Dec 7, 2018
@kpaulisse kpaulisse deleted the kpaulisse-bump-rake branch December 7, 2018 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants