Update build matrix to reflect Puppet's supported ruby version #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've noticed a problem at Braintree along the lines of:
file { '/foo':
ensure => directory,
}
file { '/bar':
ensure => directory,
require => File['/foo/'],
}
This catalog compiles and is valid, but fails validation in octocatalog-diff.
It seems that puppet itself attempts to normalize file resource titles (and indeed
can normalize any type of resource title, given that a methodology exists in the
resource type). See:
https://github.com/puppetlabs/puppet/blob/4.10.x/lib/puppet/type/file.rb#L42
This commit attmepts to mimic that (and lifts the regex directly from the 4.10.x
branch of puppet, because it doesn't matter in puppet 5 since reference validation
is built-in).
…ulisse-ruby-version-test-update
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request updates the build matrix to cover Puppet's official puppet-ruby combinations, and updates our requirements documents too. In addition, this bumps the Puppet versions used in our CI to the latest available (today) releases of 4.10.10 and 5.4.0.
This necessitated a change to one of the tests since the error message for a reference validation failure in 5.4.0 is slightly different than 5.0.0. Since #176 deals with reference validation too, I just pulled that one into here too (cc @ahayworth).