Add support for passing a list of ldap servers #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need this so we can take advantage of the `hosts` option
We don't care too much about the port in testing. Using the port in the options allows us to test against ApacheDS and OpenLDAP without adding any additional conditionals.
|
Can I make a new release too? If so v1.10.1 or v1.11.0? |
|
@lildude yep, what is your rubygems email? I can add you as an owner so you can cut releases |
I didn't have one, but I do now 😄 [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby-ldap/ruby-net-ldap#223 introduced the ability to configure net-ldap to use an array of hostnames and ports, with basic failover support.
This PR adds the ability to pass this same array to net-ldap via github-ldap so this basic failover functionality can be used by github-ldap related projects too.
/cc @jch @mtodd @sbryant