Skip to content

Bump net-ldap dependency to v0.11.x #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2015
Merged

Bump net-ldap dependency to v0.11.x #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2f51d0
Depend on net-ldap v0.11.x
mtodd May 15, 2015
c076b1a
Setup GitHub::Ldap instance with correct settings
mtodd May 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion github-ldap.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Gem::Specification.new do |spec|
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ["lib"]

spec.add_dependency 'net-ldap', '~> 0.10.0'
spec.add_dependency 'net-ldap', '~> 0.11.0'

spec.add_development_dependency "bundler", "~> 1.3"
spec.add_development_dependency 'ladle'
Expand Down
4 changes: 2 additions & 2 deletions test/filter_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative 'test_helper'

class FilterTest < Minitest::Test
class FilterTest < GitHub::Ldap::Test
class Subject
include GitHub::Ldap::Filter
def initialize(ldap)
Expand All @@ -16,7 +16,7 @@ def [](field)
end

def setup
@ldap = GitHub::Ldap.new(:uid => 'uid')
@ldap = GitHub::Ldap.new(options.merge(:uid => 'uid'))
Copy link
Member Author

@mtodd mtodd May 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but this was trying to connect to the wrong host.

It's a smell that it needs to connect on initialization but that is a separate problem.

@subject = Subject.new(@ldap)
@me = 'uid=calavera,dc=github,dc=com'
@uid = "calavera"
Expand Down