Skip to content

Conversation

@wuranbo
Copy link

@wuranbo wuranbo commented Mar 9, 2015

Make more consistency to the description in README.
I spend not a few time to know this thing, while following the README to finish my job.

Make more consistency to the description in README.
I spend not a few time to know this thing, while following the README to finish my job.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think line 17 was added by mistake: we should remove this line as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err, that's line 19 (the echo "HIIIIII" line).

@mtodd
Copy link
Member

mtodd commented May 15, 2015

Thanks for opening up this PR! Happy to merge this in, just want to clean up the unneeded line!

@wuranbo
Copy link
Author

wuranbo commented Jun 8, 2015

@mtodd Hear you are, bro~

@mtodd
Copy link
Member

mtodd commented Jun 8, 2015

@wuranbo build is red, probably because it needs master merged in. Doesn't seem related to the diff.

wuranbo added 3 commits June 9, 2015 13:37
Make more consistency to the description in README.
I spend not a few time to know this thing, while following the README to finish my job.
@wuranbo
Copy link
Author

wuranbo commented Jun 9, 2015

@mtodd I tried to rebase impertinently. But it turns out that it's not the reason. So I check the two CI failure, https://travis-ci.org/github/github-ldap/builds/65865839, https://travis-ci.org/github/github-ldap/builds/65998284。

The reason of this two failure were the CI env.Travis CI run apt-get update failed.

Get:5 http://us.archive.ubuntu.com/ubuntu/ precise/main libslp1 amd64 1.2.1-7.8ubuntu1 [50.4 kB]

Err http://us.archive.ubuntu.com/ubuntu/ precise-updates/main slapd amd64 2.4.28-1.1ubuntu4.4
404 Not Found [IP: 2001:67c:1562::13 80]
Get:6 http://us.archive.ubuntu.com/ubuntu/ precise/main time amd64 1.7-23.1 [30.6 kB]
Err http://us.archive.ubuntu.com/ubuntu/ precise-updates/main ldap-utils amd64 2.4.28-1.1ubuntu4.4
404 Not Found [IP: 2001:67c:1562::13 80]
Fetched 9,395 kB in 0s (17.0 MB/s)
Failed to fetch http://us.archive.ubuntu.com/ubuntu/pool/main/o/openldap/slapd_2.4.28-1.1ubuntu4.4_amd64.deb 404 Not Found [IP: 2001:67c:1562::13 80]
Failed to fetch http://us.archive.ubuntu.com/ubuntu/pool/main/o/openldap/ldap-utils_2.4.28-1.1ubuntu4.4_amd64.deb 404 Not Found [IP: 2001:67c:1562::13 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
The command "if [ "$TESTENV" = "openldap" ]; then ./script/install-openldap; fi" failed and exited with 100 during .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants