Skip to content

Fix dependency graph after read pkg up breaking change #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2019
Merged

Fix dependency graph after read pkg up breaking change #83

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1be58a
rename `packageJSON` to `packageFile`
koddsson Nov 28, 2019
eb07e1c
use correct `packageJson` key for package.json contents
koddsson Nov 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions lib/dependency-graph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,21 @@ exports.checkEntriesWhitelist = filename => {
}
}

const packageJSON = readPkgUp.sync()
const packageFile = readPkgUp.sync()

function recordPackageEntry(entry) {
exports.entries.add(path.resolve(packageJSON.path, '..', entry))
exports.entries.add(path.resolve(packageFile.path, '..', entry))
}

if (packageJSON) {
for (const key in packageJSON.package) {
if (packageFile) {
for (const key in packageFile.packageJson) {
if (key === 'main') {
recordPackageEntry(packageJSON.package.main)
recordPackageEntry(packageFile.packageJson.main)
} else if (key === 'entries') {
packageJSON.package.entries.forEach(recordPackageEntry)
packageFile.packageJson.entries.forEach(recordPackageEntry)
} else if (/-bundles$/.test(key)) {
// github-asset-pipeline internal manifest format
Object.keys(packageJSON.package[key]).forEach(recordPackageEntry)
Object.keys(packageFile.packageJson[key]).forEach(recordPackageEntry)
}
}
}
Expand Down