Fix allowed actions check #186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for letting us know @tjenkinson! I'll add this for the engineering team to review 💖 |
|
Closed because there is already a fix in #180 |
jnidzwetzki
pushed a commit
to jnidzwetzki/docs
that referenced
this pull request
Oct 6, 2022
* Copy-edit intro * Add raw content from KBase * Create new service * Light editing for untested bits. * Edited Installation section * Reflow * Reflow & fix image links * Remove extra whitespace * Apply suggestions from code review Co-authored-by: Ryan Booz <[email protected]> Co-authored-by: Ryan Booz <[email protected]> Co-authored-by: Jacob Prall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
I noticed the tests didn't fail in #177 when I added an action, and they should have.
What's being changed:
Fix the test and update the allow list with the things that would have failed the test if it was working.
The params to
difference()were in the wrong order.Check off the following: