Skip to content

Conversation

a2br
Copy link
Contributor

@a2br a2br commented Nov 19, 2020

What:

I have changed "main" to main.

Why:

Below the 'main' section, in the 'master' section, master is used, not "master".

@a2br a2br requested review from a team as code owners November 19, 2020 12:26
@welcome
Copy link

welcome bot commented Nov 19, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@heiskr heiskr removed the request for review from a team November 19, 2020 16:36
@janiceilene
Copy link
Contributor

@a2br Thanks so much for opening a PR! I'll get this triaged for review 💖

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Nov 20, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 27, 2020
@a2br
Copy link
Contributor Author

a2br commented Nov 28, 2020

Still waiting for review.

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Nov 28, 2020
@janiceilene
Copy link
Contributor

@a2br Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @a2br 👋🏻

Thanks for your patience. Your change to the data/glossaries/external.yml file looks good 😄

I'm less sure about the changes to the translated files. On the whole, we don't accept changes to those files but maybe formatting changes are safe. I'll check with our localization team and let you know how we can get your changes merged.

@felicitymay felicitymay self-assigned this Dec 2, 2020
@a2br
Copy link
Contributor Author

a2br commented Dec 2, 2020

Ok! I can still revert the commits on the translation files.

@felicitymay
Copy link
Contributor

Ok! I can still revert the commits on the translation files.

I hadn't noticed that they were in separate commits. That would be great. Many thanks.

a2br and others added 5 commits December 2, 2020 15:42
This reverts commit d484fd6.
This reverts commit fab62f0.
This reverts commit 78abcd6.
This squashes all the translation commits and their deletion.
@a2br
Copy link
Contributor Author

a2br commented Dec 2, 2020

Done! ✅

Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖 Many thanks for reverting those commits. This looks ready to merge now 🚢

@felicitymay felicitymay merged commit 73fdfa3 into github:main Dec 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@felicitymay felicitymay removed their assignment Dec 3, 2020
@felicitymay
Copy link
Contributor

@a2br 👋🏻 Bonjour 😄

Since I merged your pull request, I've been getting email notifications about Actions workflow failures in your fork. This puzzled me. I looked into it.

I think you enabled Actions in the settings for your fork. The failing workflow synchronizes the docs repository with our internal systems. It uses a token that your fork does not have access to. To avoid using up your Actions minutes, you should turn off actions in your fork of the docs repo (Disabling or limiting GitHub Actions for a repository).

I raised this with the docs engineering team and they will update the synchronization workflow so that it does not run on forks. The work is not scheduled yet, so it would be good to turn off actions for this repository.

@a2br
Copy link
Contributor Author

a2br commented Dec 4, 2020

Actions are now disabled in my fork ☑️

@felicitymay
Copy link
Contributor

💐 Thank you. I hope that this hasn't cause problems for you in your fork.

We usually create a feature branch from main with the changes we want to merge into the main branch of the docs repository. This would also help avoid problems like this in any future changes you propose to the docs repository.

@a2br
Copy link
Contributor Author

a2br commented Dec 4, 2020

Yes, that's what I usually do. Since the change here was very small, I thought i'd just delete my fork and re-fork if needed in the future. Thanks for the reminder though.

@felicitymay
Copy link
Contributor

That makes sense. Some of the contributors to this repository are just starting out with git and GitHub, so I thought I should mention it. It's great to hear that you already knew.

Have a great weekend 👋🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants