-
Notifications
You must be signed in to change notification settings - Fork 63.6k
Add proper markdown to 'main' #1457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As done in the description of `master`
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@a2br Thanks so much for opening a PR! I'll get this triaged for review 💖 |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
Still waiting for review. |
@a2br Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @a2br 👋🏻
Thanks for your patience. Your change to the data/glossaries/external.yml
file looks good 😄
I'm less sure about the changes to the translated files. On the whole, we don't accept changes to those files but maybe formatting changes are safe. I'll check with our localization team and let you know how we can get your changes merged.
Ok! I can still revert the commits on the translation files. |
I hadn't noticed that they were in separate commits. That would be great. Many thanks. |
Done! ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💖 Many thanks for reverting those commits. This looks ready to merge now 🚢
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
@a2br 👋🏻 Bonjour 😄 Since I merged your pull request, I've been getting email notifications about Actions workflow failures in your fork. This puzzled me. I looked into it. I think you enabled Actions in the settings for your fork. The failing workflow synchronizes the I raised this with the docs engineering team and they will update the synchronization workflow so that it does not run on forks. The work is not scheduled yet, so it would be good to turn off actions for this repository. |
Actions are now disabled in my fork ☑️ |
💐 Thank you. I hope that this hasn't cause problems for you in your fork. We usually create a feature branch from |
Yes, that's what I usually do. Since the change here was very small, I thought i'd just delete my fork and re-fork if needed in the future. Thanks for the reminder though. |
That makes sense. Some of the contributors to this repository are just starting out with git and GitHub, so I thought I should mention it. It's great to hear that you already knew. Have a great weekend 👋🏻 |
What:
I have changed "main" to
main
.Why:
Below the 'main' section, in the 'master' section,
master
is used, not "master".