Skip to content

JS: Incremental API graph #20733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

JS: Incremental API graph #20733

wants to merge 28 commits into from
+1,600 −650

Conversation

@asgerf
Copy link
Contributor

@asgerf asgerf commented Oct 31, 2025

No description provided.

@github-actions github-actions bot added the JS label Oct 31, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 31, 2025
View reviewed changes
javascript/ql/lib/semmle/javascript/ApiGraphs.qll
private import semmle.javascript.dataflow.TypeTracking
private module Stage1Input implements StageInputSig {
pragma[inline]
predicate isAdditionalUseRoot(Node node) { none() }

Check warning

Code scanning / CodeQL

Cannot inline predicate across overlay frontier Warning

This possibly local non-private inline predicate will not be inlined across the overlay frontier. This may negatively affect evaluation performance. Consider adding an overlay[caller] or overlay[caller?] annotation to allow inlining across the overlay frontier. Note that adding an overlay[caller] or overlay[caller?] annotation affects semantics under overlay evaluation.
javascript/ql/lib/semmle/javascript/ApiGraphs.qll
t = useStep(nd, promisified, boundArgs, prop, result)
}
pragma[inline]
predicate isAdditionalDefRoot(Node node) { none() }

Check warning

Code scanning / CodeQL

Cannot inline predicate across overlay frontier Warning

This possibly local non-private inline predicate will not be inlined across the overlay frontier. This may negatively affect evaluation performance. Consider adding an overlay[caller] or overlay[caller?] annotation to allow inlining across the overlay frontier. Note that adding an overlay[caller] or overlay[caller?] annotation affects semantics under overlay evaluation.
javascript/ql/lib/semmle/javascript/ApiGraphs.qll

pragma[nomagic]
private predicate shouldTrackIntoOverlay(DataFlow::SourceNode nd) {
exists(DataFlow::Node overlayNode |

Check warning

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.
javascript/ql/lib/semmle/javascript/ApiGraphs.qll

pragma[nomagic]
private predicate shouldBacktrackIntoOverlay(DataFlow::SourceNode nd) {
exists(DataFlow::Node overlayNode |

Check warning

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.
javascript/ql/lib/semmle/javascript/ApiGraphs.qll
private module Debug {
private module FullInput implements StageInputSig {
pragma[inline]
predicate isAdditionalUseRoot(Node node) { none() }

Check warning

Code scanning / CodeQL

Cannot inline predicate across overlay frontier Warning

This possibly local non-private inline predicate will not be inlined across the overlay frontier. This may negatively affect evaluation performance. Consider adding an overlay[caller] or overlay[caller?] annotation to allow inlining across the overlay frontier. Note that adding an overlay[caller] or overlay[caller?] annotation affects semantics under overlay evaluation.
javascript/ql/lib/semmle/javascript/ApiGraphs.qll
predicate inScope(DataFlow::Node node) { any() }
}

private module Full = Stage<FullInput>;

Check warning

Code scanning / CodeQL

Dead code Warning

This code is never used, and it's not publicly exported.
javascript/ql/lib/semmle/javascript/ApiGraphs.qll

private module Full = Stage<FullInput>;

query predicate missingDefNode(DataFlow::Node node) {

Check warning

Code scanning / CodeQL

Dead code Warning

This code is never used, and it's not publicly exported.
javascript/ql/lib/semmle/javascript/ApiGraphs.qll
not exists(MkDef(node))
}

query predicate missingUseNode(DataFlow::Node node) {

Check warning

Code scanning / CodeQL

Dead code Warning

This code is never used, and it's not publicly exported.
javascript/ql/lib/semmle/javascript/ApiGraphs.qll
not exists(MkUse(node))
}

query predicate lostEdge(Node pred, Label::ApiLabel lbl, Node succ) {

Check warning

Code scanning / CodeQL

Dead code Warning

This code is never used, and it's not publicly exported.
javascript/ql/lib/semmle/javascript/ApiGraphs.qll
not Cached::edge(pred, lbl, succ)
}

query predicate counts(int numEdges, int numOverlayEdges, float ratio) {

Check warning

Code scanning / CodeQL

Dead code Warning

This code is never used, and it's not publicly exported.
@asgerf asgerf force-pushed the js/incremental-api-graphs branch from 2e5779a to c8abbdc Compare November 3, 2025 10:52
@asgerf asgerf force-pushed the js/incremental-api-graphs branch from c8abbdc to e1a113c Compare November 20, 2025 10:43
asgerf added 22 commits November 20, 2025 11:44
@asgerf
JS: Make MkSyntheticCallbackArg() independent of trackUseNode
ca7735f
@asgerf
JS: Make other node types not depend on tracking predicates
dea6e5c
@asgerf
JS: Make use() and rhs() uncached and private
5cfbe0a
@asgerf
JS: Wrap in a module
1964b38 
Simply wraps everything in 'cached private module Stage {}' and adds 'import Stage'.
The diff is large because of indentation changes.
@asgerf
JS: Parameterise the module (still only one instantiation)
c23e501
@asgerf
JS: Moving 'cache' annotations outside the parameterised module
4c8089b
@asgerf
JS: Localize charpred of API::EntryPoint
5fb7e15 
This is needed for localizing ApiLabel later
@asgerf
JS: Localize MkModuleExport
ee03446
@asgerf
JS: Localize MkModuleImport
2e6baa7
@asgerf
JS: Localize MkClassInstance
8635cab
@asgerf
JS: Further localize MkDef
5cfabff
@asgerf
JS: Use forceLocal to localize MkTypeUse
b2720c4
@asgerf
JS: Remove unused predicate
ba73337
@asgerf
JS: Make API nodes and labels local
7a9b780
@asgerf
JS: Apply forceLocal overlay trick to API graphs
47e0cd3
@asgerf
JS: Stop dependeding on getPath() for toString()
56e63f2
@asgerf
JS:Add more member labels
04996c8
@asgerf
JS: Add debug predicate for detecting lost edges/nodes
599e08d
@asgerf
JS: Add MkDef case for 'export const bar = foo'
8e9e5a9
@asgerf
JS: Add MkDef case for export namespace specifiers
8d8b414
@asgerf
JS: Change signature of 'edges' to support quick eval
fb845d5
@asgerf
JS: Add back CallReceiverStep() restriction
c62a592 
This was initially lost after rebasing with indentation changes
@asgerf
JS: Add receivers to MkDef
1340d14
@asgerf
JS: Update debugging stuff in API graphs
82926db
@asgerf
JS: Add a few missing node types
413975a
@asgerf
JS: Remove global dependency that wasnt needed anyway
48c651d
@asgerf
JS: Mass overlay[local?]
7b1a01a
@asgerf
JS: Add overlay[global] to abstract classes with fields
3cb97e6 
Some abstract classes defines fields without binding them, leaving it up to the subclasses to bind them. When combined with overlay[local?], the charpred for such an abstract class can become local, while the subclasses are global. The means the charpred needs to be materialized, even though it doesn't bind the fields, leading to a cartesian product.
@asgerf asgerf force-pushed the js/incremental-api-graphs branch from e1a113c to 3cb97e6 Compare November 20, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

JS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@asgerf