Skip to content

Kotlin: Fix findTopLevelFunctionOrWarn for Kotlin 2 #14835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2023
Merged

Kotlin: Fix findTopLevelFunctionOrWarn for Kotlin 2 #14835

merged 1 commit into from
Nov 20, 2023

Conversation

@igfoo
Copy link
Contributor

@igfoo igfoo commented Nov 17, 2023

The AST when the parent class is a file class is different in Kotlin 2 mode.

@igfoo
Kotlin: Fix findTopLevelFunctionOrWarn for Kotlin 2
5c36e63 
The AST when the parent class is a file class is different in
Kotlin 2 mode.
@igfoo igfoo marked this pull request as ready for review November 17, 2023 16:39
@igfoo igfoo requested a review from a team as a code owner November 17, 2023 16:39
tamasvajk
tamasvajk approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@tamasvajk tamasvajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible.

@igfoo igfoo merged commit b8a2716 into github:main Nov 20, 2023
@igfoo igfoo deleted the igfoo/findTopLevelFunctionOrWarn branch November 20, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tamasvajk tamasvajk tamasvajk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Kotlin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@igfoo @tamasvajk