Skip to content

Type tracking: Parameterize consistency checks #14815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2023
Merged

Type tracking: Parameterize consistency checks #14815

merged 1 commit into from
Nov 20, 2023

Conversation

@hvitved
Copy link
Contributor

@hvitved hvitved commented Nov 16, 2023

Needed for Ruby, where we will allow for (irrelevant) post-update use-use steps where the origin node is not a local source node.

@hvitved hvitved added the no-change-note-required This PR does not need a change note label Nov 17, 2023
@hvitved hvitved marked this pull request as ready for review November 17, 2023 07:38
@hvitved hvitved requested a review from aschackmull November 17, 2023 07:38
aschackmull
aschackmull approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hvitved hvitved merged commit fab6813 into github:main Nov 20, 2023
@hvitved hvitved deleted the type-tracking/param-consistency-checks branch November 20, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aschackmull aschackmull aschackmull approved these changes

Assignees

No one assigned

Labels

no-change-note-required This PR does not need a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hvitved @aschackmull