Java/C++/RangeAnalysis: Move SsaReadPosition to shared qlpack. #14721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
If DCA ends up looking weird it may be worth waiting for #14720 |
aschackmull
force-pushed
the
shared/ssareadpos-share
branch
from
039b72d to
f9132c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should ideally be completely semantics-preserving as a straight refactor, but there was some weirdness around C++ SSA variables, which makes that claim non-trivial, so let's see what DCA says.
Also, I've duplicated a predicate in
SignAnalysisSpecific.qllin order to avoid C# changes in this PR - that cleanup will follow in a later PR.